Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🥚 🎡 release 0.3.4.1 to fix 0.3.4 #138

Merged
merged 1 commit into from
Nov 27, 2018
Merged

🥚 🎡 release 0.3.4.1 to fix 0.3.4 #138

merged 1 commit into from
Nov 27, 2018

Conversation

chfw
Copy link
Member

@chfw chfw commented Nov 27, 2018

…rs.rst. fix #137

Before raising the PR, here is a check list:

  1. have you written unit tests for your code changes?
  2. have you run "make format"?
  3. are you requesting to "dev"?
  4. have you updated the change log?
  5. do you think that you can understand your changes after 6 month?
    5.1) can someone else understand your changes without your explanation?
  6. are you pround of your code changes?
    6.1) do you have the feeling of achievement?

@codecov-io
Copy link

codecov-io commented Nov 27, 2018

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files          39       39           
  Lines        1800     1800           
=======================================
  Hits         1772     1772           
  Misses         28       28
Impacted Files Coverage Δ
moban/_version.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37a8ec9...4119912. Read the comment docs.

@chfw chfw merged commit 1b0e365 into master Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants