Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Output only one file #180

Closed
jayvdb opened this issue Jan 21, 2019 · 3 comments
Closed

CLI: Output only one file #180

jayvdb opened this issue Jan 21, 2019 · 3 comments
Milestone

Comments

@jayvdb
Copy link
Member

jayvdb commented Jan 21, 2019

moban -o output currently processes all files in targets:

CLI args should always take precedence of config file.

This is similar to the last sentence of

#133

@jayvdb jayvdb changed the title CLI: Output only file CLI: Output only one file Jan 21, 2019
@jayvdb jayvdb added this to the 0.4.0 milestone Jan 24, 2019
@chfw
Copy link
Member

chfw commented Feb 17, 2019

currently, mobanfile take precedence over cli, meaning if there exists a moban file, moban will process mobanfile.

Now with the presence of the mobanfile, moban receive a few params, i.e. -o 'single.output', what should moban do?

  1. single one output from targets and templating it?
  2. report error when 'single.output' is not found?

@jayvdb
Copy link
Member Author

jayvdb commented Feb 18, 2019

CLI should always take precedence over configuration files.

"The user is always right" they added CLI arguments. They shouldnt be ignored.

@chfw
Copy link
Member

chfw commented Feb 18, 2019

but with the presence of mobanfile, do you overlap the cli commands with mobanfile, meaning cli command in this case will select things from mobanfile?

the other way of handling cli, is that ignore mobanfile although it is present, then user cli commands must be complete.

chfw added a commit that referenced this issue Mar 6, 2019
…s. v0.4.1 or earlier, copy targets are executed in a separate handler, meaning at least the counter, the number of templated files are reset, and there will be two stastistics. And this change make cli target a clear priority. fix #180
@chfw chfw mentioned this issue Mar 6, 2019
@chfw chfw closed this as completed Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants