Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add installation to vk play launcher #146

Merged
merged 2 commits into from
Dec 23, 2023

Conversation

mertsalovda
Copy link
Contributor

Hello! Prepared a pull request with the addition of VK Play.

@moraroy
Copy link
Owner

moraroy commented Nov 24, 2023

Hey good work! Unfortunately for the time being I won't be able to add any new launchers just yet until the Plug-in for deck loader is passed through its currently in testing. Once that is released then I could concentrate on adding new launchers.

@moraroy
Copy link
Owner

moraroy commented Nov 26, 2023

@mertsalovda also dont forget to add the App id in the list of appids....its new code in the "Start Fresh" section in order to delete the Shader Cache associated with the launcher. You can find the appid for the launcher in the log when you install it.

@mertsalovda
Copy link
Contributor Author

@moraroy
Added app id.
Took the value from the log file
app_id_to_name: {3494943831: 'VK Play'}
This is right?

@moraroy
Copy link
Owner

moraroy commented Nov 27, 2023

@mertsalovda yes that's correct! It's just for the shader cache, also... not sure if you're aware I looked up the steamgrid cover art and steamgrid has the launcher called like this.... https://www.steamgriddb.com/game/5418177p usually I would match the Steam Shortcut name with the steamGriddb so that way it's easier for people who have the plug in to add the cover art. So you may want to change that in the python code to match the Steam Shortcut so its named correctly if that makes sense.

@mertsalovda
Copy link
Contributor Author

I plan to add images to SteamGriddb myself, which I will take from the VK Play design system.

@moraroy
Copy link
Owner

moraroy commented Nov 27, 2023

@mertsalovda gotcha OK no worries!

@moraroy moraroy merged commit 1b63221 into moraroy:main Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants