Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Implemented handling of topic alias received by publishers. Doesn't implement the alias remapping in forwarded publishes.
What does this PR do?
Updates CONNACK to set
topic alias maximum
property if user explicitly configurestopic_alias_maximum
configuration setting.Adds a topic alias to topic name cache to MQTTConnection, named
TopicAliasMapping
.Updates PUBLISH processing to handled the incoming topic alias, checking the various error condition (respect to the specification), resolve the alias to topic name and forward processing of publish message with topic name and without topic alias.
Added unit tests to MQTTConnection to cover the feature.
Why is it important/What is the impact to the user?
Implements the topic alias feature defined in the specification of MQTT 5. It handles only for incoming publishes, it doesn't apply any technique to replace topic names with aliases on the forward to subscribers phase.
Checklist
How to test this PR locally
Related issues