This repository has been archived by the owner on Dec 7, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #231
I guess these are things that changed with Python 3.
The
filter()
function now returns afilter
object, rather than a list, so it has to be converted to alist
before it can be filtered again in the loop.It seems that a string is iterable, so we need to differentiate between a list and a string, we need to specifically check is
values
is a list, not just if it is iterable.