add some extra coverage to the IBM037 encoding to extend ASCII compatibility when in FRB_COMPATIBILITY_MODE #386
+139
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for IBM1047 EBCDIC encoding compatibility with IBM037 for the three ASCII characters that differ between the encodings: [ ] ^ When FRB_COMPATIBILITY_MODE is enabled, converts IBM037 byte values to their IBM1047 equivalents before decoding: - 0xAD (Ý) -> 0xBA ([) - 0xBD (¨) -> 0xBB (]) - 0x5F (¬) -> 0xB0 (^)
atonks2
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When FRB_COMPATIBILITY_MODE is enabled, converts IBM037 byte values to their
IBM1047 equivalents before decoding:
The reason is FRB will passtrhough content from any ICL received and occasionally a variant encoding is used. As there are only 3 differences I have found within the ascii range this patch is very targetted and specific to where they have been seen in the wild but could be implemented elsewhere in the future if needed. If it becomes common enough, the support could be added to the default EBCDIC encode/decoder in reader.go