Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polygon into staging #48

Merged
merged 6 commits into from
Dec 1, 2021
Merged

Polygon into staging #48

merged 6 commits into from
Dec 1, 2021

Conversation

hmrtn
Copy link
Member

@hmrtn hmrtn commented Nov 30, 2021

This should b e possible as the only diff should be the env variables..

hmrtn
hmrtn commented Nov 30, 2021
View reviewed changes
Copy link
Member Author

@hmrtn hmrtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - worth reviewing the DAI token address for rinkeby testnet (4)

@hmrtn hmrtn temporarily deployed to polygon-pay-party November 30, 2021 14:32 Inactive
hmrtn
hmrtn commented Nov 30, 2021
View reviewed changes
Copy link
Member Author

@hmrtn hmrtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated dai token address

@hmrtn hmrtn temporarily deployed to polygon-pay-party November 30, 2021 14:39 Inactive
hmrtn
hmrtn commented Nov 30, 2021
View reviewed changes
Copy link
Member Author

@hmrtn hmrtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the currency to be env var instead of hard coded

@hmrtn hmrtn merged commit a3c0bc9 into staging Dec 1, 2021
@hmrtn hmrtn deleted the polygon branch December 15, 2021 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hmrtn