Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Submit Election button is the election do not have any candidate #46

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

damianmarti
Copy link
Member

The election can't be created if the user don't select any candidate.

Disable the button if no participant is checked as candidate.

@damianmarti damianmarti requested review from hmrtn and Cali93 November 7, 2021 13:42
@damianmarti damianmarti changed the base branch from main to staging November 7, 2021 13:42
Copy link
Member

@hmrtn hmrtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. It would also be nice to add some user feedback in the future -i.e let the user know when they've messed up.

Copy link
Collaborator

@Cali93 Cali93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super clean! Thanks Damu

@damianmarti damianmarti merged commit 2aa88eb into staging Nov 8, 2021
@hmrtn hmrtn deleted the disable-submit-election branch November 19, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants