Build own srtool #435
Merged
Build own srtool #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girazoki
added
B0-silent
Agusrodri
approved these changes
Feb 29, 2024
tmpolaczyk
reviewed
Feb 29, 2024
tmpolaczyk
approved these changes
Feb 29, 2024
Coverage Report@@ Coverage Diff @@
## master girazoki-build-own-srtool +/- ##
============================================================
Coverage 67.57% 67.57% 0.00%
Files 64 64
Lines 9241 9241
============================================================
Hits 6244 6244
Misses 2997 2997
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an issue where we need to use a specific srtool with certain components (rust-src) added, which are in this PR: paritytech/srtool#81
I modified the publish-runtime job to have the possibility to build from a custom image (and not the official parity one) that I pushed with those changes.
Additioanlly, I also added another job that instead builds from the srtool CI action. We can use one or the other.