test: add case for eth_getLogs with more than 16 addresses filtered #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pLabarta
added
B0-silent
WASM runtime size check:Compared to target branchMoonbase runtime: 2272 KB (no changes) ✅ Moonbeam runtime: 2240 KB (no changes) ✅ Moonriver runtime: 2236 KB (no changes) ✅ Compared to latest release (runtime-3200)Moonbase runtime: 2272 KB (+312 KB compared to latest release) Moonbeam runtime: 2240 KB (+316 KB compared to latest release) Moonriver runtime: 2236 KB (+312 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master pablo/regressions-eth-getlogs +/- ##
================================================================
Coverage 79.18% 79.18% 0.00%
Files 299 299
Lines 87673 87673
================================================================
Hits 69419 69419
Misses 18254 18254
|
RomarQ
requested changes
Oct 3, 2024
Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com>
RomarQ
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Tests for retrieving eth logs using more than 16 addresses as a filter. Original case was reported on block
7970232.What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?