Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XCM DryRun and LocationToAccount runtime APIs to all runtimes #2980

Merged
merged 68 commits into from
Oct 2, 2024

Conversation

Agusrodri
Copy link
Contributor

What does it do?

This PR adds both DryRun and LocationToAccount runtime APIs to Moonbase, Moonriver and Moonbeam runtimes, through runtime/common/src/apis.rs file. It also adds corresponding TS tests for these new APIs.

Related upstream PRs

gonzamontiel and others added 30 commits August 26, 2024 14:45
* add simple wasm size check

* only run on pull requests

* add Github token to env

* fix download dir name

* try comparing previous and current runtimes

* change master branch with dynamic target branch ref

* add comparison to latest release

* test with older release

* download from release instead of workflow artifact

* debug release tag not saved to env

* debug some more

* use gh cli to get releases instead of git tag

* use gh api instead of releases

* remove get build id & fix awk parsing

* build runtimes with _, releases with -

* add comment to PR and format msg

* use markdown report & replace comment

* cat report & fix comment formatting

* add twiggy diff reports as artifacts

* use upload v4 & create reports dir

* rm: deprecated ::set-output cmd
* add: storage read cost constant

* update test-pov

* update xcm-v3 tests

* update xcm-v4 tests

* add storage read gas cost to constants

* update test-precompile

* load constant in beforeAll

* replace gas cost with weight to gas ratio
…use (#2913)

* chore: rename crate manual-xcm-rpc -> moonbeam-dev-rpc

* add RPC method test_skipRelayBlocks

* allow Root to resume XCM execution

* update moonkit pin

* add dev-test that trigger auto-pause of xcm

* prettier

* dev test auto-pause xcm: remove unused imports & improve test scenario

* add pallet-emergency-para-xcm to moonriver

* add pallet-emergency-para-xcm to moonbeam

* apply review suggestions
* set the block size to 60mln gas for moonbeam

* update mbip-5 value in test
* add pallet parameters

* XcmFeesAccount

* add copyrights

* add FeesTreasuryProportion
---------

Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com>
* Add XcmRecorder to XcmConfig
* Add VersionWrapper to hrmp::COnfig
* Remove code from deprecated pallet treasury
* Remove code from deprecated DmpQueue
* Remove code from deprecated XCMV2
@Agusrodri Agusrodri added D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Sep 27, 2024
Copy link
Contributor

github-actions bot commented Sep 27, 2024

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2272 KB (no changes) ✅

Moonbeam runtime: 2240 KB (no changes) ✅

Moonriver runtime: 2236 KB (no changes) ✅

Compared to latest release (runtime-3200)

Moonbase runtime: 2272 KB (+312 KB compared to latest release) ⚠️

Moonbeam runtime: 2240 KB (+316 KB compared to latest release) ⚠️

Moonriver runtime: 2236 KB (+312 KB compared to latest release) ⚠️

Copy link
Contributor

github-actions bot commented Sep 27, 2024

Coverage Report

@@                     Coverage Diff                     @@
##           master   agustin-xcm-dry-run-api      +/-   ##
===========================================================
- Coverage   79.21%                    79.18%   -0.03%     
  Files         299                       299              
+ Lines       87636                     87673      +37     
===========================================================
  Hits        69419                     69419              
+ Misses      18217                     18254      +37     
Files Changed Coverage
/runtime/common/src/apis.rs 28.85% (-0.98%) 🔽

Coverage generated Wed Oct 2 14:39:20 UTC 2024

RomarQ
RomarQ previously approved these changes Sep 28, 2024
Copy link
Contributor

@RomarQ RomarQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me 👍

@noandrea noandrea added the A8-mergeoncegreen Pull request is reviewed well. label Sep 30, 2024
TarekkMA
TarekkMA previously approved these changes Oct 1, 2024
@pLabarta
Copy link
Contributor

pLabarta commented Oct 1, 2024

Zombie tests are now fixed on the upgrade branch, updating this one should fix them 🌈

Base automatically changed from moonbeam-polkadot-stable2407 to master October 2, 2024 13:14
@librelois librelois dismissed stale reviews from RomarQ and TarekkMA October 2, 2024 13:14

The base branch was changed.

@librelois librelois requested review from a team as code owners October 2, 2024 13:14
@Agusrodri Agusrodri merged commit 1c9dca4 into master Oct 2, 2024
39 checks passed
@Agusrodri Agusrodri deleted the agustin-xcm-dry-run-api branch October 2, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A8-mergeoncegreen Pull request is reviewed well. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants