Add support for metadata hash extension #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noandrea
added
B7-runtimenoteworthy
include the backport for CheckMetadataHash
WASM runtime size check:Compared to target branchMoonbase runtime: 2188 KB (no changes) ✅ Moonbeam runtime: 2120 KB (no changes) ✅ Moonriver runtime: 2128 KB (no changes) ✅ Compared to latest release (runtime-3101)Moonbase runtime: 2188 KB (+2188 KB compared to latest release) Moonbeam runtime: 2120 KB (+144 KB compared to latest release) Moonriver runtime: 2128 KB (+2128 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master noandrea-enable-metadata-hash +/- ##
=================================================================
- Coverage 80.92% 80.90% -0.02%
Files 286 286
+ Lines 81813 81838 +25
=================================================================
+ Hits 66205 66206 +1
+ Misses 15608 15632 +24
|
RomarQ
previously approved these changes
Sep 3, 2024
RomarQ
requested review from
TarekkMA,
librelois,
ahmadkaouk,
Agusrodri and
pLabarta
librelois
reviewed
Sep 3, 2024
librelois
reviewed
Sep 3, 2024
librelois
reviewed
Sep 3, 2024
librelois
reviewed
Sep 3, 2024
gonzamontiel
previously approved these changes
Sep 4, 2024
librelois
approved these changes
Sep 4, 2024
Agusrodri
reviewed
Sep 4, 2024
RomarQ
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Add support for metadata hash extension.
https://paritytech.github.io/polkadot-sdk/master/polkadot_sdk_docs/guides/enable_metadata_hash/index.html#integrating-metadata-hash-verification-into-your-runtime
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?