Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pallet Preimage weights #2608

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Conversation

ahmadkaouk
Copy link
Contributor

@ahmadkaouk ahmadkaouk commented Jan 2, 2024

What does it do?

New weights for pallet preimage generated with the following command

./target/production/moonbeam benchmark pallet --chain=moonbase-dev --steps=50 --repeat=20 --pallet=pallet_preimage --extrinsic=* --header=./file_header.txt --output=./runtime/common/src/weights/

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@ahmadkaouk ahmadkaouk marked this pull request as ready for review January 2, 2024 18:27
@ahmadkaouk ahmadkaouk added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Jan 2, 2024
@ahmadkaouk ahmadkaouk requested a review from librelois January 2, 2024 18:43
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Coverage Report

@@                       Coverage Diff                        @@
##           master   ahmad-pallet-preimage-weights     +/-   ##
================================================================
  Coverage   81.01%                          81.01%   0.00%     
  Files         287                             287             
+ Lines       94254                           94255      +1     
================================================================
+ Hits        76353                           76354      +1     
  Misses      17901                           17901             
Files Changed Coverage
/runtime/common/src/migrations.rs 90.67% (+1.27%) 🔼
/runtime/moonbase/src/lib.rs 50.66% (-0.07%) 🔽
/runtime/moonbeam/src/lib.rs 47.42% (-0.06%) 🔽
/runtime/moonriver/src/lib.rs 47.41% (-0.06%) 🔽

Coverage generated Wed Jan 3 08:29:41 UTC 2024

@librelois librelois merged commit 3e3253d into master Jan 3, 2024
@librelois librelois deleted the ahmad-pallet-preimage-weights branch January 3, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants