Fake VRF for ethereum pending blocks #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
B5-clientnoteworthy
librelois
added
the
not-breaking
Coverage Report@@ Coverage Diff @@
## master elois-fake-vrf-pending-blocks +/- ##
================================================================
Coverage 81.90% 81.90% 0.00%
Files 286 286
+ Lines 95242 95246 +4
================================================================
+ Hits 78001 78003 +2
+ Misses 17241 17243 +2
|
librelois
force-pushed
the
elois-fake-vrf-pending-blocks
branch
from
4f3d9cd to
c696386
Compare
noandrea
approved these changes
Nov 28, 2023
librelois
added a commit
that referenced
this pull request
Nov 28, 2023
* upgrade moonkit * upgrade frontier * implement new runtime api initialize_pending_block * update frontier pin * add zombi test with an RPC node that is not a collator * update frontier pin * fix zombi rpc tests for moonbase * add zombi rpc tests for moonbeam * Execute zombi RPC tests on CI * typo * lint * typo * zombi RPC tests: add moonbeam * lints * min gas price is higher on moonbeam * fix typo in moonwall config zombie_moonbeam_rpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Create a fake VRF mechanism for ethereum pending blocks.
The main changes are in frontier and moonkit.
Frontier changes
Add a new runtime api
initialize_pending_blockand use it inpending_runtime_apimoonbeam-foundation/frontier@3388642
Moonkit changes
Add a new fake VRF functionality in pallet randomness thought an environmental
Moonsong-Labs/moonkit@6c6cfed
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?