Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add XCM Transactor precompile V3 to Moonriver and Moonbeam #2513

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Add XCM Transactor precompile V3 to Moonriver and Moonbeam #2513

merged 2 commits into from
Oct 10, 2023

Conversation

Agusrodri
Copy link
Contributor

@Agusrodri Agusrodri commented Oct 6, 2023 •
edited
Loading

What does it do?

Enables XCM Transactor precompile V3 on Moonriver and Moonbeam chains. Also adds some typescript tests for it.

@Agusrodri Agusrodri added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. breaking Needs to be mentioned in breaking changes labels Oct 6, 2023
@Agusrodri Agusrodri marked this pull request as ready for review October 6, 2023 04:46
@Agusrodri Agusrodri requested review from fgamundi and notlesh October 6, 2023 04:50
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Coverage generated "Fri Oct 6 05:24:26 UTC 2023":
https://d3ifz9vhxc2wtb.cloudfront.net/pulls/2513/html/index.html

Master coverage: 87.39%
Pull coverage:

fgamundi
fgamundi approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@fgamundi fgamundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Agusrodri Agusrodri merged commit e173e26 into master Oct 10, 2023
@Agusrodri Agusrodri deleted the agustin-xcm-precompile-v3-moonbeam branch October 10, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgamundi fgamundi fgamundi approved these changes

@notlesh notlesh Awaiting requested review from notlesh

Assignees
No one assigned
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Agusrodri @fgamundi