Remove MinCollatorStk from parachain-staking pallet #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agusrodri
added
B7-runtimenoteworthy
|
I remember that the reason there were two different limits initially was to make sure that a collator is supported by enough delegators to be selected, with this change we assume that a collator can be selected even if it has no delegators, which is annoying since the delegators are supposed to play a security role: choosing the honest collators |
|
@librelois that is already the case. Self bonded collators can be selected at the moment. What is important is the minCandidateStk |
tmpolaczyk
approved these changes
Apr 27, 2023
Agusrodri
added
D5-nicetohaveaudit⚠️
notlesh
added
D1-audited👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR removes
MinCollatorStkconstant present inparachain-stakingpallet.The reason for removing it is that now both amounts
MinCollatorStkandMinCandidateStkare the same, so it doesn't make any sense to have them duplicated. In this case, we keep usingMinCandidateStk(minimum stake required for any account to be a collator candidate). Another reason is that it's even dangerous to have this constant (MinCollatorStk) as if the candidate gets under that amount, it won’t get included in the collators set, even if there are free slots. This could stall the chain.