-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some dependencies #2263
Update some dependencies #2263
Conversation
Your changes duplicate the |
@librelois yeah, that's unfortunate, but the only version of enumflags2 that has not been yanked is using syn 2: https://crates.io/crates/enumflags2/versions This is the advisory that explains why it has been yanked, it probably doesn't affect us so I could remove that upgrade from this PR: But I believe that it is impossible to get all of the dependencies to upgrade from syn 1 to syn 2 simultaneously, so we will encounter this problem again in the future. |
@tmpolaczyk can you cleanup this PR or close if not needed anymore please ? |
Coverage generated "Fri May 26 07:12:47 UTC 2023": Master coverage: 70.88% |
Updated with master. The syn dependency is already duplicated in master so that's no longer a problem for this PR. |
Thank you @tmpolaczyk |
What does it do?
Updates some dependencies to fix warnings about
remove_dir_all
andenumflags2
.chrono
andtime
are also updated, but that doesn't fix anything.Is there something left for follow-up PRs?
Getting rid of the
chrono
dependency would be nice as that issues some false positives regarding to thetime
crate.