Change GMP precompile to rely only on amount transferred #2244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Internally, Wormhole does some "normalization" of asset amounts, relying on the wrapper ERC20's
decimals()
to modify the amount specified in the payload. The following fn is internally called by the bridge wheredecimals
is taken from the ERC20:The fix is quite simple: just detect the amount transferred (this was already done) and ignore the amount in the payload (previously we took the
min()
of the two).While the fix is simple, I'd like a better understanding of the design behind the normalization technique, and I'd also like a way to catch this in tests.