-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix collators not producing blocks when selected candidates is zero #2231
Conversation
I'm unsure whether I am missing something, so I would like to see a test proving this. Also adding @librelois to the review. I think the pr is correct though The proposed test should: potentially insert manually candidates with less than minStk on storage, go to a round session change, and call this runtime API. I think this would prove that the we are doing correct things |
Added test for the generic case when compute_top_candidates returns an empty vec, by doing:
|
What does it do?
Fix collators not producing blocks when selected candidates is zero.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?