Limit the max number of assets weighable in XCM #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
B7-runtimenoteworthy
|
Just to be clear on what this PR does: if I withdraw 15 assets (nothing prevents me today from doing that) I will be charged as if I was withdrawing 10. Is this the behavior we want? I see statemint applies 100 so I just want to be sure we are doing what we want here: |
Good point, the limit applied in the weigher should be equal the the limit applied by the executor, so |
tgmichel
approved these changes
Apr 11, 2023
girazoki
approved these changes
Apr 11, 2023
crystalin
changed the title
imstar15
pushed a commit
to AvaProtocol/moonbeam
that referenced
this pull request
May 16, 2023
* XCM: Limit the max number of assets weighable * apply a more reasonable limit for max assets * MAX_ASSETS should be equal to MaxAssetsIntoHolding
notlesh
added
D1-audited👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
To prevent unreasonably high count values from overweighing related XCM instructions, we should have an upper limit on how many assets we would weight during the weight calculation of XCM and we should apply this limit to all *Counted variants.
This PR also apply the same limit for
MAX_ASSETSandMaxAssetsIntoHolding.The maximum number of "weighable" assets has been reduced from 100 to 64.
This means that if you try to send an XCM message that tries to handle more than 64 assets at the same time, it will still fail as before, but the weigher will charge less.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?