Allow calling proxy.proxy from smart contracts in moonbase #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpolaczyk
added
B7-runtimenoteworthy
|
Can we also remove this section in this PR, and add tests to ensure calls from users/contracts/precompiles behave as expected? |
|
So do we want to allow proxy calls from any kind of precompile? |
nanocryk
reviewed
Mar 6, 2023
| @@ -173,7 +173,7 @@ type MoonbasePrecompilesAt<R> = ( | |||
| AddressU64<2059>, | |||
| ProxyPrecompile<R>, | |||
| ( | |||
| CallableByContract<OnlyIsProxy<R>>, | |||
| CallableByContract<OnlyIsProxyAndProxy<R>>, | |||
| SubcallWithMaxNesting<0>, | |||
| // Batch is the only precompile allowed to call Proxy. | |||
| CallableByPrecompile<OnlyFrom<AddressU64<2056>>>, | |||
There was a problem hiding this comment.
Do do we want to allow proxy calls from any kind of precompile?
No, it just conflicts with the filters declared with the PrecompileSetBuilder. No idea why this check is still done in the precompile, as it was necessary before we had opt-in checks in PrecompileSetBuilder.
This was actually preventing the batch precompile from being able to call proxy precompile
nanocryk
approved these changes
Mar 8, 2023
notlesh
added
D1-audited👍
imstar15
pushed a commit
to AvaProtocol/moonbeam
that referenced
this pull request
May 16, 2023
…foundation#2148) * allow calling proxy.proxy from smart contracts in moonbase * Remove redundant is_precompile check * Rename proxy_force_type to proxyForceType * Compile contracts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Allows smart contracts to call
Proxy.proxyandProxy.proxy_force_type. This only affects the moonbase runtime.Allows precompiles to call
Proxy.proxy(only batch precompile by default, which was already defined but not working).Rename
proxy_force_typetoproxyForceType.Related to #2098