Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ParachainSystem pallet to non-transfer proxy #2088

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Adds ParachainSystem pallet to non-transfer proxy #2088

merged 2 commits into from
Feb 13, 2023

Conversation

crystalin
Copy link
Collaborator

No description provided.

@crystalin crystalin added A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Feb 9, 2023
notlesh
notlesh reviewed Feb 9, 2023
View reviewed changes
runtime/moonbase/src/lib.rs
@@ -911,6 +911,7 @@ impl InstanceFilter<RuntimeCall> for ProxyType {
matches!(
c,
RuntimeCall::System(..)
| RuntimeCall::ParachainSystem(..)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This warning about 10 lines above (L905) looks important:

// Be careful: Each time this filter is modified, the EVM filter must also be modified consistently.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parachainSystem is not offered as a precompile so it doesn't require changing the EVM filter for now

@crystalin crystalin merged commit 216eeb4 into master Feb 13, 2023
@crystalin crystalin deleted the crystalin-parachain-system-proxy branch February 13, 2023 18:00
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
@imstar15
Adds ParachainSystem pallet to non-transfer proxy (moonbeam-foundatio…
b2fac44 
…n#2088)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notlesh notlesh notlesh approved these changes

@girazoki girazoki girazoki approved these changes

Assignees
No one assigned
Labels
A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crystalin @notlesh @girazoki