Add OpenGov precompile logs #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgmichel
added
A0-pleasereview
# Conflicts: # precompiles/referenda/src/lib.rs
4meta5
reviewed
Feb 8, 2023
4meta5
reviewed
Feb 8, 2023
4meta5
reviewed
Feb 8, 2023
4meta5
reviewed
Feb 8, 2023
4meta5
suggested changes
Feb 8, 2023
There was a problem hiding this comment.
handle.record_log_costs_manual(X, Y)?; should go at the top of the precompile function body before calls are dispatched
We do not want the calls to dispatch successfully and then the precompile function fails because the caller doesn't have enough gas to pay log costs cc @nanocryk
4meta5
approved these changes
Feb 9, 2023
# Conflicts: # precompiles/preimage/src/lib.rs # precompiles/preimage/src/mock.rs # precompiles/preimage/src/tests.rs
nanocryk
approved these changes
Feb 14, 2023
notlesh
approved these changes
Feb 14, 2023
imstar15
pushed a commit
to AvaProtocol/moonbeam
that referenced
this pull request
May 16, 2023
* Add vote_yes/no logs * Comment * Wip more conviction voting logs * wip convition voting * wip preimage * conviction voting record costs * Add tests preimage * cleanup * Use Hashing assoc type instead Blake explicitly * Add referenda logs * Wip referenda log tests * referenda log tests * past tense convention for naming events * updated test * record log costs first * fmt * Merge branch 'master' into tgm-opengov-precompile-logs # Conflicts: # precompiles/preimage/src/lib.rs # precompiles/preimage/src/mock.rs # precompiles/preimage/src/tests.rs * Fix version * Cleanup after rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds logs to
ConvictionVoting,PreimageandReferendaprecompiles.ConvictionVoting
Vote: only when the vote is succesful either yes/no. Frame event: No.VoteRemove: only when the voter is succesfully removed from an ongoing poll. Frame event: No.VoteRemoveOther: only when the target voter is succesfully removed. Frame event: Yes.Delegate: only when the caller succesfully delegates its vote to target. Frame event: Yes.Undelegate: only when the caller succesfully undelegates a previously delegated target. Frame event: Yes.Unlock: always emited whenunlockis called, even if there is no unlockeable amount for the account. Frame event: No.Preimage
PreimageNoted: only when the preimage is succesfully registered. Frame event: Yes.PreimageUnnoted: only when the preimage is succesfully de-registered. Frame event: Yes.Referenda
SubmittedAt: only when the referendum is succesfully created. Frame event: Yes.SubmittedAfter: only when the referendum is succesfully created. Frame event: Yes.DecisionDepositPlaced: only when the deposit is succesfully placed. Frame event: Yes.DecisionDepositRefunded: only when the deposit is succesfully refunded. Frame event: Yes.What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?