Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Staking precompile getters: getDelegatorTotalStaked and getCandidateTotalBacked #2033

Merged
merged 4 commits into from
Jan 11, 2023

Conversation

nanocryk
Copy link
Contributor

@nanocryk nanocryk commented Jan 9, 2023

What does it do?

Add two new getters to the staking precompile.

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@nanocryk nanocryk added A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes C1-low Does not elevate a release containing this beyond "low priority". D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Jan 9, 2023
@nanocryk nanocryk added the not-breaking Does not need to be mentioned in breaking changes label Jan 10, 2023
@nanocryk nanocryk merged commit 6924ede into master Jan 11, 2023
@nanocryk nanocryk deleted the jeremy-more-precompile-getters branch January 11, 2023 10:43
@crystalin crystalin changed the title Staking precompile: getDelegatorTotalStaked and getCandidateTotalBacked getters Add Staking precompile getters: getDelegatorTotalStaked and getCandidateTotalBacked Jan 20, 2023
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
…ed getters (moonbeam-foundation#2033)

* getDelegatorTotalStaked in staking precompile

* getCandidateTotalBacked

* rename function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes C1-low Does not elevate a release containing this beyond "low priority". D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants