Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOON-1941] use AllPalletsWithSystem for hook order #1937

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

nbaztec
Copy link
Contributor

@nbaztec nbaztec commented Nov 8, 2022

What does it do?

uses AllPalletsWithSystem for hook order in favor of the deprecated AllPalletsReversedWithSystemFirst

What important points reviewers should know?

The hook order should be verified/tested that the block authoring hooks aren't affected.

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@nbaztec nbaztec added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Nov 8, 2022
Copy link
Contributor

@notlesh notlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have failed to find any reason this would break, so I'll approve with the caveat that "absence of evidence is not evidence of absence [of a dependency which this would break]."

@nbaztec
Copy link
Contributor Author

nbaztec commented Nov 10, 2022

I performed a fork-test with this branch and it seemed to have been producing blocks normally. I'll go ahead and merge this.

@nbaztec nbaztec merged commit a85f733 into master Nov 10, 2022
@nbaztec nbaztec deleted the nish-all-pallets-reverse-fix branch November 10, 2022 15:22
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Dec 14, 2022
@zqhxuyuan zqhxuyuan mentioned this pull request Mar 13, 2023
12 tasks
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants