Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive AccountId20 from keccak digest directly #1870

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Derive AccountId20 from keccak digest directly #1870

merged 1 commit into from
Dec 20, 2022

Conversation

conr2d
Copy link
Contributor

@conr2d conr2d commented Oct 14, 2022

What does it do?

This PR instantiates H160 from Keccak256::digest directly without H256 conversion.

@nanocryk nanocryk added A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Oct 21, 2022
nanocryk
nanocryk approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@nanocryk nanocryk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can you marge latest master into your branch or rebase?

primitives/account/src/lib.rs Outdated Show resolved Hide resolved
@nanocryk
Copy link
Contributor

Run cargo fmt and we should be good :)

@nanocryk nanocryk merged commit b917fa7 into moonbeam-foundation:master Dec 20, 2022
@conr2d conr2d deleted the derive-account-id branch February 14, 2023 06:33
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
@conr2d @imstar15
Derive AccountId20 from keccak digest directly (moonbeam-foundation#1870
5c2368f 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanocryk nanocryk nanocryk approved these changes

Assignees
No one assigned
Labels
A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conr2d @nanocryk