Enable ProofSizeExt when estimating gas and emit ReportRefund when PoV gas is the effective gas #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…V gas is the effective gas
crystalin
reviewed
Nov 27, 2024
RomarQ
added a commit
that referenced
this pull request
Dec 2, 2024
…V gas is the effective gas (#235)
manuelmauro
pushed a commit
that referenced
this pull request
Feb 11, 2025
…V gas is the effective gas (#235)
manuelmauro
pushed a commit
that referenced
this pull request
Feb 12, 2025
…V gas is the effective gas (#235)
manuelmauro
pushed a commit
that referenced
this pull request
Feb 17, 2025
…V gas is the effective gas (#235)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the gas calculation when using tracing or eth_estimateGas/eth_call RPC's.
Important notes:
If the estimated proof size is lower than the proof_size obtained from the host-function, the
estimated proof sizeis used. We have some underestimations that need to be identified an fixed in a followup pull request.