Add support for multi-arch images built with GHA (7.4) #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add environment variable to allow scripts to make decissions. - Remove x86 harcoded dependency. - Disable sqlsrv and oracle drivers for non amd64 builds (they need research). With these changes it's possible to build both amd64 and arm64 images. Need this is place to continue testing the new multi-arch automated builders from GHA (that will replace DockerHub builds, because, amazingly, they don't support multi-arch yet). Once built the multi-arch images, we'll be pushing them both to DockerHub and also to GH own registry.
|
Some notes, this has been already tested with the You can see how it's working @:
Both are correctly tagged and have images for Also, the automated builds @ dockerhub have been disabled already, because this GHA, once merged will be in charge of all the new builds. |
scara
reviewed
Aug 15, 2021
First attempt to switch the automated building of moodle-php-apache images from DockerHub to GHA. Main reason being that the former doesn't support multiarch builds (only multiarch storage). Link: docker/hub-feedback#1874 Experimentally we'll be, also, sending the images to both DockerHub and GitHub registries in case we need to switch some day. This requires: 1. Some secrets to be created: - DOCKERHUB_USERNAME - DOCKERHUB_TOKEN (write perms) - DOCKERHUB_PASSWORD, grrr, descriptions cannot be updated using PATs, see peter-evans/dockerhub-description#10 - GH_USERNAME 2. Autobuilds @ DockerHub to be disabled (this takes exactly on them) Remove old dockerhub hook, because now GHA is in charge of tagging.
|
self-merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First cut to moodle-php-apache multiarch builder
First attempt to switch the automated building of moodle-php-apache
images from DockerHub to GHA. Main reason being that the former doesn't
support multiarch builds (only multiarch storage).
Link: docker/hub-feedback#1874
Experimentally we'll be, also, sending the images to both DockerHub
and GitHub registries in case we need to switch some day.
This requires:
see Doesn't work with Docker Hub access tokens peter-evans/dockerhub-description#10
Remove old dockerhub hook, because now GHA is in charge of tagging.