Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete version attribute from compose files. #283

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

paulholden
Copy link
Member

$ bin/moodle-docker-compose up -d
WARN[0000] /home/pholden/Moodle/Docker/base.yml: `version` is obsolete 
WARN[0000] /home/pholden/Moodle/Docker/service.mail.yml: `version` is obsolete 
WARN[0000] /home/pholden/Moodle/Docker/db.mysql.yml: `version` is obsolete 
WARN[0000] /home/pholden/Moodle/Docker/db.mysql.port.yml: `version` is obsolete 
WARN[0000] /home/pholden/Moodle/Docker/selenium.debug.yml: `version` is obsolete 
WARN[0000] /home/pholden/Moodle/Docker/webserver.port.yml: `version` is obsolete 
[+] Running 5/6
 ⠴ Network docker_default        Created                                                                                                                                                                                                                                   
 ✔ Container docker-exttests-1   Started                                                                                                                                                                                                                                   
 ✔ Container docker-selenium-1   Started                                                                                                                                                                                                                                   
 ✔ Container docker-mailpit-1    Started                                                                                                                                                                                                                                   
 ✔ Container docker-db-1         Started                                                                                                                                                                                                                                   
 ✔ Container docker-webserver-1  Started

Local versions:

$ docker --version
Docker version 25.0.5, build 5dc9bcc
$ docker compose version
Docker Compose version v2.25.0

`WARN[0000] <path>: `version` is obsolete`
@stronk7
Copy link
Member

stronk7 commented Mar 20, 2024

Ok, I've tried here with current Desktop release:

$ docker --version
Docker version 25.0.3, build 4debf41
stronk7@~/git_moodle/moodle-docker (main >)$ docker compose version 
Docker Compose version v2.24.6-desktop.1

And it works perfectly. Curiously I don't get the warnings here (maybe that's something that has been added recently), neither get them if I run docker compose config -f xxxx.

In any case, I'm near sure that the change should be safe (I think that we have commented about the deprecation of those versions in past issues here). So going to merge this now.

If somebody is using any docker compose alternative that faces problems with this change, I imagine that will share the (negative) experience here.

Ciao :-)

@stronk7 stronk7 merged commit 766ddef into moodlehq:main Mar 20, 2024
113 checks passed
@paulholden paulholden deleted the obsolete-version branch March 20, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants