chore: Update activeIndex value in RunDetailsGraph to setActiveIndex(…

…RunDetailsTab.Logs)
montara-io · Jun 3, 2024 · 4bbb8d1 · 4bbb8d1
1 parent 5cb8326
commit 4bbb8d1
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 23 deletions.
diff --git a/web/src/RunDetails/RunDetailsGraph/index.tsx b/web/src/RunDetails/RunDetailsGraph/index.tsx
@@ -71,7 +71,7 @@ function RunDetailsGraph({
           emptyMessage="No lineage data available. Please refresh the page to try again."
           onNodeMenuClick={(p) => {
             p.menuId === NodeMenuId.ShowError &&
-              setActiveIndex(RunDetailsTab.Issues);
+              setActiveIndex(RunDetailsTab.Logs);
           }}
           isFilterByPipelineEnabled={false}
         />

diff --git a/web/src/RunDetails/RunDetailsModels.tsx b/web/src/RunDetails/RunDetailsModels.tsx
@@ -20,7 +20,6 @@ import { LARGE_FONT_SIZE } from "../constants/style-units";
 import { useContext, useEffect, useState } from "react";
 import { MainContext } from "../Main";
 import { MainActionType } from "../main.redux";
-import { AnalyticsEvent, trackEvent } from "../services/analytics";
 
 const StyledRunDetailsModels = styled.div``;
 
@@ -32,12 +31,6 @@ function RunDetailsModels({
   const [runningModels, setRunningModels] = useState<string[]>([]);
   const [, mainDispatch] = useContext(MainContext);
 
-  useEffect(() => {
-    trackEvent({
-      eventName: AnalyticsEvent.UserViewedRunDetailsModels,
-    });
-  }, []);
-
   useEffect(() => {
     const allRunningModels = (runData?.getRunById?.modelRunsDetails ?? []).map(
       (m) => m.name

diff --git a/web/src/RunDetails/RunLog/index.tsx b/web/src/RunDetails/RunLog/index.tsx
@@ -1,7 +1,5 @@
 import styled from "styled-components";
 import LogViewer from "../../stories/LogViewer";
-import { AnalyticsEvent, trackEvent } from "../../services/analytics";
-import { useEffect } from "react";
 
 type RunLogProps = {
   dbtLog: string;
@@ -14,11 +12,6 @@ const StyledRunLog = styled.div`
 `;
 
 function RunLog({ dbtLog }: Readonly<RunLogProps>) {
-  useEffect(() => {
-    trackEvent({
-      eventName: AnalyticsEvent.UserViewedRunLogs,
-    });
-  }, []);
   return (
     <StyledRunLog>
       <LogViewer log={dbtLog ?? ""} />

diff --git a/web/src/RunDetails/helpers.tsx b/web/src/RunDetails/helpers.tsx
@@ -254,8 +254,7 @@ export function getModelRunStatusMap(
 export enum RunDetailsTab {
   Pipeline,
   Models,
-  Validations,
-  Issues,
+  Logs,
 }
 
 export const ValidationNameToLabelMap: Record<DbtRunTestErrorType, string> = {

diff --git a/web/src/RunDetails/index.tsx b/web/src/RunDetails/index.tsx
@@ -61,6 +61,17 @@ function RunDetails() {
     !runData?.getRunById?.status ||
     runData?.getRunById?.status === GenericStatus.in_progress;
 
+  useEffect(() => {
+    trackEvent({
+      eventName:
+        activeIndex === RunDetailsTab.Pipeline
+          ? AnalyticsEvent.UserViewedRunDetailsGraph
+          : activeIndex === RunDetailsTab.Logs
+          ? AnalyticsEvent.UserViewedRunLogs
+          : AnalyticsEvent.UserViewedRunDetailsModels,
+    });
+  }, [activeIndex]);
+
   useEffect(() => {
     async function getRunResultsJson() {
       if (isInProgressRun) {
@@ -90,12 +101,6 @@ function RunDetails() {
     getRunResultsJson();
   }, [isInProgressRun, runData]);
 
-  useEffect(() => {
-    trackEvent({
-      eventName: AnalyticsEvent.UserViewedRunDetailsGraph,
-    });
-  }, []);
-
   useEffect(() => {
     const interval = setInterval(async () => {
       if (!isInProgressRun) return;