Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove correctly the locale at the beginning of the route #69

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Remove correctly the locale at the beginning of the route #69

merged 1 commit into from
Jun 24, 2024

Conversation

maximehuran
Copy link
Member

@maximehuran maximehuran commented Jun 24, 2024 •
edited
Loading

Example with a en route and news slug.

Before

In URL en/news, the ltrim keep ws

After

In URL en/news, the preg replace keep news
The regex uses ^ to be sure we only remove the locale at the beginning of the slug.

See #64 which introduced the issue

@madamebiz madamebiz added the quick win Easy to pick, everybody will be happy. label Jun 24, 2024
@madamebiz madamebiz added Status: needs review Status: needs review labels Jun 24, 2024
@maximehuran maximehuran merged commit f1a5036 into monsieurbiz:master Jun 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delyriand delyriand delyriand approved these changes

@lanfisis lanfisis Awaiting requested review from lanfisis

@Kiwikoti Kiwikoti Awaiting requested review from Kiwikoti

Assignees
No one assigned
Labels
quick win Easy to pick, everybody will be happy. Status: needs review Status: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximehuran @delyriand @madamebiz