Skip to content

Commit

Permalink
Roll back standalone to npm@8.x.x, remove redundant configs (firebase…
Browse files Browse the repository at this point in the history
…#6300)

* Roll back standalone to npm@8.x.x, remove redundant configs

* Adding CHANGELOG entry
  • Loading branch information
joehan authored and JulienMartel committed Aug 25, 2023
1 parent 3815db3 commit 0519d79
Show file tree
Hide file tree
Showing 4 changed files with 54 additions and 58 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fixed an issue where builds from https://firebase.tools could not run commands that spawn `npm`. (#6132)
1 change: 0 additions & 1 deletion standalone/firepit.js
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@ let runtimeBinsPath = path.join(homePath, ".cache", "firebase", "runtime");
const npmArgs = [
`--script-shell=${runtimeBinsPath}/shell${isWindows ? ".bat" : ""}`,
`--globalconfig=${path.join(runtimeBinsPath, "npmrc")}`,
`--userconfig=${path.join(runtimeBinsPath, "npmrc")}`,
`--scripts-prepend-node-path=auto`
];

Expand Down
108 changes: 52 additions & 56 deletions standalone/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 0519d79

Please sign in to comment.