Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targets improvements #175

Merged
merged 7 commits into from
Jan 23, 2024
Merged

Targets improvements #175

merged 7 commits into from
Jan 23, 2024

Conversation

mhutch
Copy link
Member

@mhutch mhutch commented Jan 23, 2024

No description provided.

When using CPS project system, fixes transform on save and displays relevant item metadata
in VS property window.
Output items for templates and preprocessed templates now have InputFIle and Dependencies
metadata.
Apparently when we tried to pack a TFM-specific file called _._ into
buildTransitive to indicate that there were no targets for that TFM,
NuGet arbitrarily decided to pack the targets file from a different TFM
instead ¯\_(ツ)_/¯

Borrow the logic from https://github.com/dotnet/runtime/blob/bb74bb79db53eae474977a0928756a0db7fc6a3f/src/libraries/Microsoft.Extensions.Configuration.Binder/src/buildTransitive/Microsoft.Extensions.Configuration.Binder.targets#L17
as it's easier than overriding NuGet's weird pack behavior.

Fixes #174
When relative pragmas are enabled, and includes already have relative
path, and there is no base bath from which to calculate relative paths,
use the existing relative path as-is.
@mhutch mhutch merged commit 9b6fc72 into main Jan 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant