Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assembly load priorities when using AssemblyLoadContext #173

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Fix assembly load priorities when using AssemblyLoadContext #173

merged 2 commits into from
Jan 11, 2024

Commits on Jan 10, 2024

  1. Fix AssemblyLoadContext assembly loading behavior 

    The behavior should now be equivalent to that of the AppDomain codepath:
assemblies are loaded from referenced assembly paths only after
failing to resolve them from loaded assemblies in the host context
and after the runtime fails to resolve them from the default context.
    @mhutch
    mhutch committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    2aea692 View commit details
    Browse the repository at this point in the history

  2. Give host ResolveAssemblyReference priority over reference paths 

    The list of assembly files referenced by the template may contain
reference assemblies, which will fail to load. Letting the host attempt
to resolve the assembly first gives it an opportunity to resolve runtime
assemblies.

Ideally we would have a robust mechanism for resolving runtime
assemblies bue this will have to serve as a stopgap.
    @mhutch
    mhutch committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    ad28c47 View commit details
    Browse the repository at this point in the history