Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up build targets package #161

Merged
merged 8 commits into from
Oct 2, 2023
Merged

Clean up build targets package #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
eeb818c
Add readme and update schema for build targets
mhutch Feb 15, 2023
e79515f
Use build-term resx generator
mhutch Feb 16, 2023
ddfdc83
Make encoded vs explicit metadata consistent
mhutch Feb 16, 2023
7f8bd58
Reformat the package readme to make nuget happy
mhutch Feb 16, 2023
d56e59e
Fix refs to renamed target
mhutch Jun 14, 2023
79742bb
Update the MSBuild schema
mhutch Oct 2, 2023
5d13d8b
Add LICENSE.txt to packages
mhutch Oct 2, 2023
72b685d
Fix empty item metadata overwriting encoded value
mhutch Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"files.associations": {
"*.buildschema.json": "jsonc"
},
"json.schemas": [
{
"fileMatch": [
"/*.buildschema.json"
],
"url": "https://raw.githubusercontent.com/mhutch/MonoDevelop.MSBuildEditor/main/MonoDevelop.MSBuild/Schemas/buildschema.json"
}
],
"cSpell.words": [
"Preprocess",
"reimplementation"
]
}
4 changes: 4 additions & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
<PackageReference Include="Nerdbank.GitVersioning" Version="3.6.133" PrivateAssets="all" />
</ItemGroup>

<ItemGroup>
<None Include="$(MSBuildThisFileDirectory)LICENSE" Pack="true" PackagePath="LICENSE.txt" Visible="False" />
</ItemGroup>

<!-- reproducible build -->
<PropertyGroup>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
Expand Down
289 changes: 0 additions & 289 deletions Mono.TextTemplating.Build/Messages.Designer.cs
View file
Open in desktop

This file was deleted.

12 changes: 6 additions & 6 deletions Mono.TextTemplating.Build/Messages.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,19 +127,19 @@
<value>Failed to save T4 build state. All T4 files will be reprocessed on next run.</value>
</data>
<data name="DirectiveProcessorDoesNotHaveThreeValues" xml:space="preserve">
<value>Directive processor '{0}' could not be split into 'name!class!assembly' components</value>
</data>
<data name="DirectiveProcessorMissingComponent" xml:space="preserve">
<value>Directive processor '{0}' is missing component '{1}'</value>
<value>Directive processor '{0}' has encoded form with incorrect number of components</value>
</data>
<data name="DirectiveProcessorNoAssembly" xml:space="preserve">
<value>Directive processor '{0}' has no 'Assembly' metadata</value>
</data>
<data name="DirectiveProcessorNoClass" xml:space="preserve">
<value>Directive processor '{0}' has no 'Class' metadata</value>
</data>
<data name="LoadedStateFile" xml:space="preserve">
<value>Loaded state file '{0}'</value>
</data>
<data name="ParameterNoValue" xml:space="preserve">
<value>Template parameter '{0}' has neither 'Value' metadata nor a value encoded in the name</value>
<data name="ArgumentNoValue" xml:space="preserve">
<value>Template argument '{0}' has no 'Value' metadata</value>
</data>
<data name="RecoverableInternalError" xml:space="preserve">
<value>T4 engine encountered a recoverable internal error. Although it should not affect output, please report it as it may affect reliability and performance.</value>
Expand Down
15 changes: 13 additions & 2 deletions Mono.TextTemplating.Build/Mono.TextTemplating.Build.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,19 @@
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="17.0.0" PrivateAssets="all" IncludeAssets="compile" />
</ItemGroup>

<!-- https://github.com/dotnet/msbuild/issues/4751-->
<PropertyGroup>
<CoreCompileDependsOn>PrepareResources;$(CompileDependsOn)</CoreCompileDependsOn>
</PropertyGroup>

<ItemGroup>
<Compile Update="Messages.Designer.cs" DesignTime="True" AutoGen="True" DependentUpon="Messages.resx" />
<EmbeddedResource Update="Messages.resx" Generator="ResXFileCodeGenerator" LastGenOutput="Messages.Designer.cs" />
<EmbeddedResource
Update="@(EmbeddedResource)"
StronglyTypedLanguage="CSharp"
StronglyTypedClassName="%(Filename)"
StronglyTypedNamespace="$(RootNamespace)"
Generator="MSBuild:Compile"
StronglyTypedFileName="$(IntermediateOutputPath)\%(StronglyTypedNamespace).%(StronglyTypedClassName).Designer.cs"
LogicalName="%(StronglyTypedNamespace).%(StronglyTypedClassName).resources" />
</ItemGroup>
</Project>
17 changes: 16 additions & 1 deletion Mono.TextTemplating.Build/Mono.TextTemplating.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,25 @@
</PropertyGroup>

<ItemDefinitionGroup>
<!-- hide T4 key/value pairs from the solution tree -->
<!-- hide T4 key/value pairs and other non-file items from the solution tree -->
<T4ParameterValues>
<Visible>False</Visible>
</T4ParameterValues>
<T4Argument>
<Visible>False</Visible>
</T4Argument>
<DirectiveProcessor>
<Visible>False</Visible>
</DirectiveProcessor>
<T4ReferencePath>
<Visible>False</Visible>
</T4ReferencePath>
<T4IncludePath>
<Visible>False</Visible>
</T4IncludePath>
<T4AssemblyReference>
<Visible>False</Visible>
</T4AssemblyReference>
<!-- transform on save in VS -->
<T4Transform>
<Generator>MSBuild:TransformAll</Generator>
Expand Down
Loading
Loading