Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide functions that opengl32.dll does not actually have #2710

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

mattleibow
Copy link
Contributor

Description of Change

Do not provide invalid externs as they may cause issues later on or with code that scans assemblies for valid functions.

Bugs Fixed

  • API Scan warnings/errors

API Changes

None.

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow mattleibow merged commit 408ddd1 into release/2.x Jan 12, 2024
1 of 2 checks passed
@mattleibow mattleibow deleted the dev/opengl32 branch January 12, 2024 18:25
mattleibow added a commit that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant