Update bitmap SKAlphaType in SKXamlCanvas.Wasm.cs #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To obtain the expected built bitmap by skia, we need to change the SKAlphaType of the build image. Opaque doesn't give correct results when bluring none opaque colors for example. Premul doesn't work either for a particular reason: In javascript we use the ImageData API. The ImageData API store the pixels as un-premultiplied. So if we use the premultiplied enum value we end up with wrong pixel colors (same result as Opaque in fact). I tested unpremul value in a project that is using blur, and it gives the correct results.
mattleibow
approved these changes
Jun 12, 2023
|
@roubachof is there a way to create a test? Right now we have no way to capture the image, but some drawing code that I can run against this PR to test? Is it just a batter of drawing two different blocks, or is it blending with other elements? |
|
When this PR will be merged (very soon I hope :) You will be able to test it with the WASM target of the Uno toolkit sample => Control => ShadowContainer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To obtain the expected built bitmap by skia, we need to change the SKAlphaType of the build image. Opaque doesn't give correct results when bluring colors with alpha for example. Premul doesn't work either for a particular reason: In javascript we use the ImageData API.
The ImageData API store the pixels as un-premultiplied. So if we use the premultiplied enum value we end up with wrong pixel colors (same result as Opaque in fact). I tested unpremul value in a project that is using blur, and it gives the correct results.