feat: Move to JSImport for WinUI Target on net7.0 #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromelaban
force-pushed
the
dev/jela/uno-net7
branch
2 times, most recently
from
202bddb to
6866524
Compare
mattleibow
reviewed
Jun 12, 2023
...e/SkiaSharp.Views.Uno/SkiaSharp.Views.Uno.WinUI.Wasm/WasmScripts/SkiaSharp.Views.Uno.Wasm.js
Show resolved
Hide resolved
jeromelaban
force-pushed
the
dev/jela/uno-net7
branch
3 times, most recently
from
852f825 to
1219944
Compare
jeromelaban
force-pushed
the
dev/jela/uno-net7
branch
2 times, most recently
from
26e4904 to
e13146e
Compare
mattleibow
reviewed
Jun 19, 2023
...arp.Views.Uno/SkiaSharp.Views.Uno.WinUI.Reference/SkiaSharp.Views.Uno.WinUI.Reference.csproj
Outdated
Show resolved
Hide resolved
source/SkiaSharp.Views.Uno/SkiaSharp.Views.Uno.WinUI.Wasm/SkiaSharp.Views.Uno.WinUI.Wasm.csproj
Outdated
Show resolved
Hide resolved
Until dotnet build can be used. The sample is still built under windows.
Needed until uno.ui can be updated to 4.6 or later, as the uno-runtime folder now supports the net7.0 structure, and is incompatible with uno 4.5 or earlier.
jeromelaban
force-pushed
the
dev/jela/uno-net7
branch
from
b81894b to
9505bed
Compare
jeromelaban
force-pushed
the
dev/jela/uno-net7
branch
from
6ffe13d to
92e18a1
Compare
jeromelaban
force-pushed
the
dev/jela/uno-net7
branch
from
16e260a to
989b1dd
Compare
mattleibow
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds net7.0 support for
SkiaSharp.Views.Uno.WinUI.WasmBugs Fixed
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist