[ci] Add exclusions for PoliCheck and CredScan #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an exclusions file for policheck to allow it to ignore the sources in the `third_party` folder that we do not own.
|
This cuts the issue set down dramatically (from Latest failing run from main: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7141188&view=logs&j=20168050-bfe6-5e92-c15c-a5eae27a73d9&t=dc840bab-140a-508c-d5e2-ec42cf763889&l=2674 |
pjcollins
changed the title
|
The new versions of the tools have uncovered some more issues, but we've gone from 2617 down to 169 in the latest run and now have a better starting point to resolve the rest. This should be ready to go. |
Redth
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a exclusion files for CredScan and PoliCheck to ignore third party
sources and a mathematical term used as a variable name in number of
places. The versions of the compliance and reporting tasks used have
also been updated.
The new
source.gdnsuppressfile is used to exclude specific terms fromPoliCheck, as the
PoliCheckExclusions.xmlfile does not allow verygranular control. This file is generated and uploaded by the build, and
the generated file can be used to update the in-tree file to exclude
more terms in the future as needed.