-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wasm): Add mt and mt+simd, fix harfbuzz for emsdk 3.1.12 #2286
Conversation
Do all these changes affect both libSkiaSharp and libHarfBuzzSharp? I can't recall if this did both. |
It looks like it does not, I'll make the change there as well. |
In a separate PR I'll try get wasm tests to run in all these combos. |
54efc28
to
8784f17
Compare
cba3d79
to
8abdd5f
Compare
8abdd5f
to
7d7e475
Compare
Sorry to ask it here. Are you using the last harfbuzz (V 6x)? |
I'm still getting the error: |
Description of Change
Adds explicit support for multi-threaded and SIMD combinations.
Bugs Fixed
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist