Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PNG loading issues by updating the zlib to one with fixes #2045

Merged
merged 8 commits into from
May 18, 2022

Conversation

mattleibow
Copy link
Contributor

@mattleibow mattleibow commented May 17, 2022

Description of Change

It appears zlib has some issues with certain PNG files, but they were fixed in a later version. I have selected the version that skia main/master uses for 2 reasons:

  • Safety because that is what the google/skia tests are running
  • Breaking changes are happening a bit later, so I don't want to touch too many things right before a release

Bugs Fixed

API Changes

None.

Behavioral Changes

Less PNG loading errors

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Updated documentation

@Vercidium
Copy link

Thanks for the quick turnaround Matt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants