Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft implementation for using clang's AST node visitor. (Not fully functional nor complete)
The current implementation is based on clang's JSONNodeDumper, but the plan is to replace all the stringified properties with setting the raw data on nodes.
So this works like:
Visit(const clang::<BaseType>*)
> (eg.void ASTNodeVisitor::Visit(const Stmt* S)
)InnerStmtVisitor::Visit()
Visit<MostDerivedType>
>Convert<MostDerivedType>(clang::<NodeType>, AST::<NodeType>)
Convert...
will then callConvert...Impl
on itself and it's base typesConvert...Impl
is the exact same code as is generated intoParseExpr/Stmt.h
, in other words, with a little bit of work it should be possible to apply this for expr/stmt parsing right now