Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Add flag to prevent deletion of build files #73

Open
TheCrypt0 opened this issue Aug 26, 2022 · 2 comments · May be fixed by #75 or #77
Open

[Request] Add flag to prevent deletion of build files #73

TheCrypt0 opened this issue Aug 26, 2022 · 2 comments · May be fixed by #75 or #77

Comments

@TheCrypt0
Copy link

This would be great especially when running local server builds: https://community.mongoose-os.com/t/optimize-private-server-builds/2498/5?u=thecrypt0

At the moment it seems like it always gets executed: build_remote.go#L61

@TheCrypt0
Copy link
Author

@rojer Any update on this? I would love to submit a PR with the update but I've never really worked in go and don't have the machine configured to work on this codebase.

Not really a PR but in pseudocode:

Step 1: Create the --keep-build-dir (KeepBuildDir) flag in flags.go
Step 2: Check if *flags.KeepBuildDir is true and if so, skip the os.RemoveAll(buildDir) build_remote.go#L61
Step 3: Profit!

Let me know if this simple change can be integrated 😄

plinss added a commit to plinss/mos that referenced this issue Jan 27, 2023
@plinss plinss linked a pull request Jan 27, 2023 that will close this issue
plinss added a commit to plinss/mos that referenced this issue Feb 1, 2023
@plinss plinss linked a pull request Feb 1, 2023 that will close this issue
@plinss
Copy link

plinss commented Feb 1, 2023

I submitted two PRs for this, I think I prefer the approach in #77

plinss added a commit to plinss/mos that referenced this issue Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants