Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two changes #10

Closed
wants to merge 11 commits into from
Closed

Two changes #10

wants to merge 11 commits into from

Conversation

iamnader
Copy link
Contributor

@iamnader iamnader commented Feb 2, 2011

  1. added a find_by_#{slug_name}_or_id : self-explanatory

  2. added a "first_value" option (might need a better name). with this option if you pass multiple fields to your slug it looks for the first one that has a value and uses that.

@iamnader
Copy link
Contributor Author

iamnader commented Feb 2, 2011

oops, just remembered that we discussed #1 a while ago and you said it didn't work with embedded docs. Not sure if this is still the case. Regardless you might find #2 useful.

@iamnader
Copy link
Contributor Author

iamnader commented Feb 3, 2011

Ok, I removed find_by_slug_or_id, I changed the option to :any, and I added a spec.

Thanks

@hakanensari
Copy link
Collaborator

I somehow missed your last comment.

Done.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamnader @hakanensari