Rename backing fields (so that they don't clash with devise)

[stulentsev]

Posting PR as requested in https://github.com/afeld/mongoid-locker/issues/26

[dblock]

This is not backward compatible and will leave a lot of garbage fields in existing documents set to nil I believe. I think we don't want to merge this without the customizing feature.

Either way, this also needs an entry in CHANGELOG and potentially create an UPGRADING document. Thx.

[stulentsev]

Got it, thanks.

[dblock]

You can keep it open! Just add to this PR.

[afeld]

I think we don't want to merge this without the customizing feature.

I'm fine with a minor version bump and instructions about how to clean up the old fields, but could go either way. Customizability seems less pressing with the more specific field name.

[stulentsev]

Who's in charge here? :)

[afeld]

It's @dblock's world, I just live in it 👸

[dblock]

"Agreement" in something like this is when everybody can live with the results, even if sometimes they don't "love" it ;)

The biggest issue I see with renaming the field is that cleanup is particularly complicated for existing projects across all models. We use this gem in a lot of places and if I am not mistaken there're a lot of instances that have a nil value for the lock field right now. So we would need to unset these, which is potentially a very large operation, multiplied by many models.

I am happy to help with customization if it seems too hard @stulentsev, btw. Do you want to try it or do you need help?

[stulentsev]

@dblock I want to try it. And then I'll likely ask for help :)

[dblock]

Bump @stulentsev

[stulentsev]

@dblock hah, you know how it is. You solve the immediate problem and then there are more pressing things to attend to. :)
I'll devote a couple of hours this weekend.

[dblock]

I'm going to close this for now. There's a lot more work here to be done for it to be merged and there be dragons with renaming fields, anyone who feels like it can pick it up. See above for comments.

[stulentsev]

yeah...