-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds support for disabling Backup Compliance Policy on resource delete #2953
base: master
Are you sure you want to change the base?
Conversation
APIx bot: a message has been sent to Docs Slack channel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small docs change, one question
@@ -6,7 +6,7 @@ When enabled, the Backup Compliance Policy will be applied as the minimum backup | |||
|
|||
-> **NOTE:** Groups and projects are synonymous terms. You might find `groupId` in the official documentation. | |||
|
|||
-> **IMPORTANT NOTE:** Once enable a Backup Compliance Policy, no user, regardless of role, can disable the Backup Compliance Policy via Terraform, or any other method, without contacting MongoDB support. This means that once enabled some resources defined in Terraform will no longer be modifiable. See the full list of [Backup Compliance Policy Prohibited Actions and Considerations](https://www.mongodb.com/docs/atlas/backup/cloud-backup/backup-compliance-policy/#configure-a-backup-compliance-policy) | |||
-> **IMPORTANT NOTE:** Once a Backup Compliance Policy is enabled, no user, regardless of role, can disable the Backup Compliance Policy via Terraform, or any other method, without contacting MongoDB support. Only once approved for disablement from support, the resource can be removed and the delete operation will successfully disable the Backup Compliance Policy. This means that once enabled some resources defined in Terraform will no longer be modifiable. See the full list of [Backup Compliance Policy Prohibited Actions and Considerations](https://www.mongodb.com/docs/atlas/backup/cloud-backup/backup-compliance-policy/#configure-a-backup-compliance-policy). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny edit to make more clear
-> **IMPORTANT NOTE:** Once a Backup Compliance Policy is enabled, no user, regardless of role, can disable the Backup Compliance Policy via Terraform, or any other method, without contacting MongoDB support. Only once approved for disablement from support, the resource can be removed and the delete operation will successfully disable the Backup Compliance Policy. This means that once enabled some resources defined in Terraform will no longer be modifiable. See the full list of [Backup Compliance Policy Prohibited Actions and Considerations](https://www.mongodb.com/docs/atlas/backup/cloud-backup/backup-compliance-policy/#configure-a-backup-compliance-policy). | |
-> **IMPORTANT NOTE:** Once a Backup Compliance Policy is enabled, no user, regardless of role, can disable the Backup Compliance Policy via Terraform, or any other method, without contacting MongoDB support. However, if BCP is approved for disablement via the support process, the resource can be removed and the delete operation will successfully disable the Backup Compliance Policy. With Backup Compliance Policy enabled some resources defined in Terraform will no longer be modifiable. See the full list of [Backup Compliance Policy Prohibited Actions and Considerations](https://www.mongodb.com/docs/atlas/backup/cloud-backup/backup-compliance-policy/#configure-a-backup-compliance-policy). |
"MongoDB Support and complete an extensive verification process. ") | ||
|
||
d.SetId("") | ||
connV2 := meta.(*config.MongoDBClient).AtlasV2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question - did we check if the error is clear from the API endpoint if we run delete and it's not marked as deletable? Not quite our purview but we can push back on the creating team if it's not clear (since that could be really confusing for Terraform users if it's not).
Description
Link to any related issue(s): CLOUDP-294102 (supporting new delete operation), CLOUDP-293109 (docs clarification)
Tested locally (cloud-dev) that the removal of the resource effectively disabled the Backup Compliance Policy in Atlas UI. In cloud-dev there is no pre-requisite of Disablement Approval. Internal KB has all the details of the process, mentioning how API delete operation fits in.
Type of change:
Required Checklist:
Further comments