Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Adds import block syntax and use L2 heading to show in sidebar #2930

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

EspenAlbert
Copy link
Collaborator

@EspenAlbert EspenAlbert commented Dec 26, 2024

Description

Adds import block syntax and fixes indent level of heading (see image below)

Link to any related issue(s): CLOUDP-273976 #2550

image

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@github-actions github-actions bot added the bug label Dec 26, 2024
@@ -34,7 +34,7 @@ export MONGODB_ATLAS_ENABLE_PREVIEW="true"

trap 'rm -R docs-out/' EXIT # temp dir cleanup when script exits

tfplugindocs generate --tf-version "${TF_VERSION}" --website-source-dir "${TEMPLATE_FOLDER_PATH}" --rendered-website-dir "docs-out"
tfplugindocs generate --tf-version "${TF_VERSION}" --website-source-dir "${TEMPLATE_FOLDER_PATH}" --rendered-website-dir "docs-out" --provider-name "mongodbatlas"
Copy link
Collaborator Author

@EspenAlbert EspenAlbert Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supports running from a directory that doesn't use the conventional folder name of terraform-provider-mongodbatlas

@EspenAlbert EspenAlbert changed the title doc: Adds import block syntax and fixes indent level of heading doc: Adds import block syntax and use L2 heading Dec 26, 2024
@EspenAlbert EspenAlbert changed the title doc: Adds import block syntax and use L2 heading doc: Adds import block syntax and use L2 heading to show in sidebar Dec 26, 2024
@EspenAlbert EspenAlbert removed the bug label Dec 26, 2024
@EspenAlbert EspenAlbert marked this pull request as ready for review December 26, 2024 16:29
@EspenAlbert EspenAlbert requested review from a team as code owners December 26, 2024 16:29
Copy link
Contributor

APIx bot: a message has been sent to Docs Slack channel

Copy link

@erabil-mdb erabil-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

github-actions bot commented Jan 5, 2025

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@github-actions github-actions bot added the stale label Jan 5, 2025
@EspenAlbert EspenAlbert added not_stale Not stale issue or PR and removed stale labels Jan 7, 2025
@@ -212,7 +212,7 @@ Read-Only:

- `valid` (Boolean) Flag that indicates whether the Google Cloud Key Management Service (KMS) encryption key can encrypt and decrypt data.

# Import
## Import
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EspenAlbert good catch!

I don't know if it's easy to see if it's happening in other docs, e.g. search string " #" only appears in first line of the docs

@EspenAlbert EspenAlbert merged commit c13ae3b into master Jan 10, 2025
67 checks passed
@EspenAlbert EspenAlbert deleted the CLOUDP-273976_import_docs branch January 10, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not_stale Not stale issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants