Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixes acceptance and migrations tests not running in CI #1907

Merged
merged 28 commits into from
Feb 6, 2024

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Feb 5, 2024

Description

Fixes acceptance and migrations tests not running in CI.

  • unify test skip in acc.SkipTestForCI, removed SkipTest, SkipIfTFAccNotDefined, SkipTestExtCred.
  • only 1 backup test group
  • only 1 federated test group
  • Data Lake tests fixed to run in CI.
  • LDAP Configuration and Verify tests enabled in CI.

Link to any related issue(s): CLOUDP-226641

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@lantoli lantoli changed the title chore: Fixes acceptance and migtrations tests not running in CI chore: Fixes acceptance and migrations tests not running in CI Feb 5, 2024
@lantoli lantoli force-pushed the CLOUDP-226641_test_not_ci branch from 57afed9 to 66ad515 Compare February 5, 2024 21:32
@lantoli lantoli marked this pull request as ready for review February 6, 2024 07:24
@lantoli lantoli requested a review from a team as a code owner February 6, 2024 07:24
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

@@ -16,35 +16,37 @@ import (
)

func TestAccClusterRSGlobalCluster_basic(t *testing.T) {
acc.SkipTestForCI(t) // needs to be fixed: "cloud_backup": conflicts with backup_enabled
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create a CLOUDP and add it to this comment? this would help us to track the work needed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure but let me first take a look at all Skip tests to see if they could be in the Test project or they can be non-epic stories

@lantoli lantoli merged commit f1ef5a0 into master Feb 6, 2024
37 of 41 checks passed
@lantoli lantoli deleted the CLOUDP-226641_test_not_ci branch February 6, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants