-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fixes acceptance and migrations tests not running in CI #1907
Conversation
57afed9
to
66ad515
Compare
internal/testutil/acc/skip.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 💯
@@ -16,35 +16,37 @@ import ( | |||
) | |||
|
|||
func TestAccClusterRSGlobalCluster_basic(t *testing.T) { | |||
acc.SkipTestForCI(t) // needs to be fixed: "cloud_backup": conflicts with backup_enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you create a CLOUDP and add it to this comment? this would help us to track the work needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure but let me first take a look at all Skip tests to see if they could be in the Test project or they can be non-epic stories
Description
Fixes acceptance and migrations tests not running in CI.
Link to any related issue(s): CLOUDP-226641
Type of change:
Required Checklist:
Further comments