Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrades teams resource to auto-generated SDK #1905

Merged
merged 15 commits into from
Feb 5, 2024
Merged

Conversation

oarbusi
Copy link
Collaborator

@oarbusi oarbusi commented Feb 2, 2024

Description

Upgrades teams resource to auto-generated SDK.

Migration tests created.

Link to any related issue(s): CLOUDP-226093

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@oarbusi oarbusi marked this pull request as ready for review February 5, 2024 13:25
@oarbusi oarbusi requested a review from a team as a code owner February 5, 2024 13:25
@@ -45,3 +45,11 @@ func ExpandStringListFromSetSchema(set *schema.Set) []string {
}
return res
}

func ExpandStringPointerListFromSetSchema(set *schema.Set) *[]string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[optional] misc.go seems like good candidate for sdk-go class.

ImportState: true,
ImportStateVerify: true,
},
},
})
}

func testAccCheckMongoDBAtlasTeamExists(resourceName string, team *matlas.Team) resource.TestCheckFunc {
func checkExists(resourceName string, team *admin.Team) resource.TestCheckFunc {
Copy link
Member

@lantoli lantoli Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think team param is needed, i've changed in other resources to have checkExists only with resourceName and use normal resource.TestCheckResourceAttr for checking all attributes we want, e.g: https://github.com/mongodb/terraform-provider-mongodbatlas/pull/1897/files#diff-ffad5b36ece89e3e5aec3c355741582e635a69feae36b8ff4538ff08a2f04f6aR91

@oarbusi oarbusi merged commit e519c3c into master Feb 5, 2024
38 checks passed
@oarbusi oarbusi deleted the CLOUDP-226093 branch February 5, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants