-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrades teams
resource to auto-generated SDK
#1905
Conversation
internal/common/conversion/misc.go
Outdated
@@ -45,3 +45,11 @@ func ExpandStringListFromSetSchema(set *schema.Set) []string { | |||
} | |||
return res | |||
} | |||
|
|||
func ExpandStringPointerListFromSetSchema(set *schema.Set) *[]string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[optional] misc.go seems like good candidate for sdk-go class.
ImportState: true, | ||
ImportStateVerify: true, | ||
}, | ||
}, | ||
}) | ||
} | ||
|
||
func testAccCheckMongoDBAtlasTeamExists(resourceName string, team *matlas.Team) resource.TestCheckFunc { | ||
func checkExists(resourceName string, team *admin.Team) resource.TestCheckFunc { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think team param is needed, i've changed in other resources to have checkExists only with resourceName and use normal resource.TestCheckResourceAttr for checking all attributes we want, e.g: https://github.com/mongodb/terraform-provider-mongodbatlas/pull/1897/files#diff-ffad5b36ece89e3e5aec3c355741582e635a69feae36b8ff4538ff08a2f04f6aR91
Description
Upgrades
teams
resource to auto-generated SDK.Migration tests created.
Link to any related issue(s): CLOUDP-226093
Type of change:
Required Checklist:
Further comments