Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.8.0 - Fix test failures #1022

Merged
merged 2 commits into from
Jan 24, 2023
Merged

v1.8.0 - Fix test failures #1022

merged 2 commits into from
Jan 24, 2023

Conversation

evertsd
Copy link
Contributor

@evertsd evertsd commented Jan 24, 2023 •
edited
Loading

Description

  • Fixed replicationSpecsHashSet which was improperly updated to cast region_configs to a slice of interface. region_configs is a *schema.Set in all existing usages of that function.
  • Added oplog_min_retention_hours property to the advancedConfigurationSchema for cluster data_source

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@evertsd evertsd requested a review from a team as a code owner January 24, 2023 01:12
@Zuhairahmed Zuhairahmed self-requested a review January 24, 2023 01:14
Zuhairahmed
Zuhairahmed approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

martinstibbe
martinstibbe approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@martinstibbe martinstibbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zuhairahmed Zuhairahmed merged commit c1642a1 into master Jan 24, 2023
@Zuhairahmed Zuhairahmed deleted the v1.8.0_rs_hash_fix branch January 27, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zuhairahmed Zuhairahmed Zuhairahmed approved these changes

@martinstibbe martinstibbe martinstibbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evertsd @martinstibbe @Zuhairahmed